Browse Source

basic support for multiple conditions added - WIP

master
vjs22334 5 years ago
parent
commit
ca22eb792d
  1. 130
      Assets/Fungus/Scripts/Commands/VariableCondition.cs
  2. 36
      Assets/Fungus/Scripts/Editor/VariableConditionEditor.cs

130
Assets/Fungus/Scripts/Commands/VariableCondition.cs

@ -6,29 +6,85 @@ using System.Collections.Generic;
namespace Fungus namespace Fungus
{ {
[System.Serializable]
public class conditionExpression
{
[SerializeField] protected CompareOperator compareOperator;
[SerializeField] protected AnyVariableAndDataPair anyVar;
public virtual AnyVariableAndDataPair AnyVar { get { return anyVar; } }
public virtual CompareOperator CompareOperator { get { return compareOperator; } }
public conditionExpression(){}
public conditionExpression(CompareOperator op, AnyVariableAndDataPair variablePair)
{
compareOperator = op;
anyVar = variablePair;
}
}
// anyone with a better name for this can update it
public enum AnyOrAllConditions
{
AnyOneTrue,
AllTrue
}
public abstract class VariableCondition : Condition, ISerializationCallbackReceiver public abstract class VariableCondition : Condition, ISerializationCallbackReceiver
{ {
[Tooltip("The type of comparison to be performed")] [Tooltip("The type of comparison to be performed")]
[SerializeField] protected CompareOperator compareOperator;
[SerializeField] protected AnyVariableAndDataPair anyVar = new AnyVariableAndDataPair(); [SerializeField] protected AnyOrAllConditions anyOrAllConditions;
[SerializeField] protected List<conditionExpression> conditions = new List<conditionExpression>();
protected override bool EvaluateCondition() protected override bool EvaluateCondition()
{ {
if (anyVar.variable == null) if (conditions == null || conditions.Count == 0)
{ {
return false; return false;
} }
bool condition = false; bool resultAny = false, resultAll = true;
anyVar.Compare(compareOperator, ref condition); foreach (conditionExpression condition in conditions)
{
bool curResult = false;
if (condition.AnyVar == null)
{
resultAll &= curResult;
resultAny |= curResult;
continue;
}
condition.AnyVar.Compare(condition.CompareOperator, ref curResult);
Debug.Log("res : " + curResult.ToString());
resultAll &= curResult;
resultAny |= curResult;
}
return condition; if (anyOrAllConditions == AnyOrAllConditions.AnyOneTrue) return resultAny;
return resultAll;
} }
protected override bool HasNeededProperties() protected override bool HasNeededProperties()
{ {
return (anyVar.variable != null); if( conditions == null || conditions.Count == 0){
return false;
}
foreach (conditionExpression condition in conditions)
{
if(condition.AnyVar == null || condition.AnyVar.variable == null){
return false;
}
}
return true;
} }
#region Public members #region Public members
@ -36,18 +92,40 @@ namespace Fungus
/// <summary> /// <summary>
/// The type of comparison operation to be performed. /// The type of comparison operation to be performed.
/// </summary> /// </summary>
public virtual CompareOperator CompareOperator { get { return compareOperator; } } public virtual CompareOperator CompareOperator { get { return conditions[0].CompareOperator; } }
public virtual List<conditionExpression> Conditions { get { return conditions; } }
public override string GetSummary() public override string GetSummary()
{ {
if (anyVar.variable == null) if (!this.HasNeededProperties())
{ {
return "Error: No variable selected"; return "Error: No variable selected";
} }
string summary = anyVar.variable.Key + " "; string summary = "";
summary += VariableUtil.GetCompareOperatorDescription(compareOperator) + " "; string connector = "";
summary += anyVar.GetDataDescription(); if(anyOrAllConditions == AnyOrAllConditions.AnyOneTrue){
connector = " Or ";
}
else{
connector = " And ";
}
for(int i = 0 ; i < conditions.Count; i++)
{
summary += conditions[i].AnyVar.variable.Key + " ";
summary += VariableUtil.GetCompareOperatorDescription(conditions[i].CompareOperator) + " ";
summary += conditions[i].AnyVar.GetDataDescription();
if(i<conditions.Count-1){
summary += connector;
}
}
return summary; return summary;
} }
@ -61,6 +139,10 @@ namespace Fungus
#region backwards compat #region backwards compat
[SerializeField] protected CompareOperator compareOperator;
[SerializeField] protected AnyVariableAndDataPair anyVar;
[Tooltip("Variable to use in expression")] [Tooltip("Variable to use in expression")]
[VariableProperty(AllVariableTypes.VariableAny.Any)] [VariableProperty(AllVariableTypes.VariableAny.Any)]
@ -120,11 +202,10 @@ namespace Fungus
void ISerializationCallbackReceiver.OnAfterDeserialize() void ISerializationCallbackReceiver.OnAfterDeserialize()
{ {
if (variable == null)
if( variable != null)
{ {
return;
}
else
{ {
anyVar.variable = variable; anyVar.variable = variable;
} }
@ -214,6 +295,23 @@ namespace Fungus
//moved to new anyvar storage, clear legacy. //moved to new anyvar storage, clear legacy.
variable = null; variable = null;
} }
// just checking for anyVar != null fails here. is any var beig reintilaized somewhere?
if(anyVar != null && anyVar.variable != null){
conditionExpression c = new conditionExpression(compareOperator,anyVar);
if(!conditions.Contains(c)){
conditions.Add(c);
}
//added to list
anyVar = null;
//this is not nullabale?
//compareOperator = null;
}
}
#endregion #endregion
} }
} }

36
Assets/Fungus/Scripts/Editor/VariableConditionEditor.cs

@ -33,8 +33,10 @@ namespace Fungus.EditorUtils
new GUIContent(VariableUtil.GetCompareOperatorDescription(CompareOperator.NotEquals)), new GUIContent(VariableUtil.GetCompareOperatorDescription(CompareOperator.NotEquals)),
}; };
protected SerializedProperty compareOperatorProp; // protected SerializedProperty compareOperatorProp;
protected SerializedProperty anyVarProp; // protected SerializedProperty anyVarProp;
protected SerializedProperty conditions;
protected Dictionary<System.Type, SerializedProperty> propByVariableType; protected Dictionary<System.Type, SerializedProperty> propByVariableType;
@ -42,14 +44,24 @@ namespace Fungus.EditorUtils
{ {
base.OnEnable(); base.OnEnable();
compareOperatorProp = serializedObject.FindProperty("compareOperator"); // compareOperatorProp = serializedObject.FindProperty("compareOperator");
anyVarProp = serializedObject.FindProperty("anyVar"); // anyVarProp = serializedObject.FindProperty("anyVar");
conditions = serializedObject.FindProperty("conditions");
} }
public override void DrawCommandGUI() public override void DrawCommandGUI()
{ {
serializedObject.Update(); serializedObject.Update();
EditorGUILayout.PropertyField(serializedObject.FindProperty("anyOrAllConditions"));
conditions.arraySize = EditorGUILayout.IntField("Size", conditions.arraySize);
for (int i = 0; i < conditions.arraySize; i++)
{
VariableCondition t = target as VariableCondition; VariableCondition t = target as VariableCondition;
var flowchart = (Flowchart)t.GetFlowchart(); var flowchart = (Flowchart)t.GetFlowchart();
@ -58,10 +70,14 @@ namespace Fungus.EditorUtils
return; return;
} }
EditorGUILayout.PropertyField(anyVarProp, true); // EditorGUILayout.PropertyField(anyVarProp, true);
var conditionAnyVar = conditions.GetArrayElementAtIndex(i).FindPropertyRelative("anyVar");
var conditionCompare = conditions.GetArrayElementAtIndex(i).FindPropertyRelative("compareOperator");
EditorGUILayout.PropertyField(conditionAnyVar,new GUIContent("Variable"),true);
// Get selected variable // Get selected variable
Variable selectedVariable = anyVarProp.FindPropertyRelative("variable").objectReferenceValue as Variable; Variable selectedVariable = conditionAnyVar.FindPropertyRelative("variable").objectReferenceValue as Variable;
GUIContent[] operatorsList = emptyList; GUIContent[] operatorsList = emptyList;
if (selectedVariable != null) if (selectedVariable != null)
{ {
@ -69,7 +85,7 @@ namespace Fungus.EditorUtils
} }
// Get previously selected operator // Get previously selected operator
int selectedIndex = (int)t.CompareOperator; int selectedIndex = (int)t.Conditions[i].CompareOperator;
if (selectedIndex < 0) if (selectedIndex < 0)
{ {
// Default to first index if the operator is not found in the available operators list // Default to first index if the operator is not found in the available operators list
@ -84,7 +100,11 @@ namespace Fungus.EditorUtils
if (selectedVariable != null) if (selectedVariable != null)
{ {
compareOperatorProp.enumValueIndex = selectedIndex; conditionCompare.enumValueIndex = selectedIndex;
}
} }

Loading…
Cancel
Save