Merge pull request #610 from ionite34/mac-fixes

Fix some crashes on macOS & linux

Avalonia.Gif/Avalonia.Gif.csproj

@@ -10,7 +10,7 @@
 		<EnableWindowsTargeting>true</EnableWindowsTargeting>
   </PropertyGroup>
   <ItemGroup>
-    <PackageReference Include="Avalonia" Version="11.0.10" />
+    <PackageReference Include="Avalonia" Version="$(AvaloniaVersion)" />
     <PackageReference Include="SkiaSharp" Version="2.88.7" />
 	<PackageReference Include="DotNet.Bundle" Version="0.9.13" />
   </ItemGroup>

CHANGELOG.md

@@ -9,6 +9,10 @@ and this project adheres to [Semantic Versioning 2.0](https://semver.org/spec/v2
 ### Fixed
 - Fixed more crashes when loading invalid connected model info files
 - Fixed pip installs not parsing comments properly
+- Fixed crash when sending input to a process that isn't running
+- Fixed [#576](https://github.com/LykosAI/StabilityMatrix/issues/576) - drag & drop crashes on macOS & Linux
+- Fixed [#594](https://github.com/LykosAI/StabilityMatrix/issues/594) - missing thumbnails in Inference model selector
+- Downgraded Avalonia back to 11.0.9 to fix [#589](https://github.com/LykosAI/StabilityMatrix/issues/589) and possibly other rendering issues
 
 ## v2.10.1
 ### Added

Directory.Build.props

@@ -0,0 +1,5 @@
+<Project>
+    <PropertyGroup>
+        <AvaloniaVersion>11.0.9</AvaloniaVersion>
+    </PropertyGroup>
+</Project>

StabilityMatrix.Avalonia.Diagnostics/StabilityMatrix.Avalonia.Diagnostics.csproj

@@ -19,8 +19,8 @@
     </ItemGroup>
 
     <ItemGroup>
-      <PackageReference Include="Avalonia" Version="11.0.10" />
-      <PackageReference Include="Avalonia.Controls.DataGrid" Version="11.0.10" />
+      <PackageReference Include="Avalonia" Version="$(AvaloniaVersion)" />
+      <PackageReference Include="Avalonia.Controls.DataGrid" Version="$(AvaloniaVersion)" />
       <PackageReference Include="DotNet.Bundle" Version="0.9.13" />
       <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="8.0.0" />
       <PackageReference Include="Microsoft.Extensions.Hosting" Version="8.0.0" />

StabilityMatrix.Avalonia/Extensions/DataObjectExtensions.cs

@@ -1,4 +1,5 @@
-using Avalonia.Input;
+using System.Runtime.InteropServices;
+using Avalonia.Input;
 
 namespace StabilityMatrix.Avalonia.Extensions;
 
@@ -9,9 +10,16 @@ public static class DataObjectExtensions
     /// </summary>
     public static T? GetContext<T>(this IDataObject dataObject)
     {
-        if (dataObject.Get("Context") is T context)
+        try
         {
-            return context;
+            if (dataObject.Get("Context") is T context)
+            {
+                return context;
+            }
+        }
+        catch (COMException)
+        {
+            return default;
         }
 
         return default;

StabilityMatrix.Avalonia/StabilityMatrix.Avalonia.csproj

@@ -39,17 +39,17 @@
         <PackageReference Include="AsyncImageLoader.Avalonia" Version="3.2.1" />
         <PackageReference Include="AutoComplete.Net" Version="1.2211.2014.42"/>
         <PackageReference Include="Avalonia.AvaloniaEdit" Version="11.0.6" />
-        <PackageReference Include="Avalonia.Controls.DataGrid" Version="11.0.10" />
-        <PackageReference Include="Avalonia.Controls.ItemsRepeater" Version="11.0.10" />
-        <PackageReference Include="Avalonia.Controls.PanAndZoom" Version="11.0.0.3" />
-        <PackageReference Include="Avalonia" Version="11.0.10" />
-        <PackageReference Include="Avalonia.Desktop" Version="11.0.10" />
-        <PackageReference Include="Avalonia.Fonts.Inter" Version="11.0.10" />
+        <PackageReference Include="Avalonia.Controls.DataGrid" Version="$(AvaloniaVersion)" />
+        <PackageReference Include="Avalonia.Controls.ItemsRepeater" Version="$(AvaloniaVersion)" />
+        <PackageReference Include="Avalonia.Controls.PanAndZoom" Version="11.0.0.2" />
+        <PackageReference Include="Avalonia" Version="$(AvaloniaVersion)" />
+        <PackageReference Include="Avalonia.Desktop" Version="$(AvaloniaVersion)" />
+        <PackageReference Include="Avalonia.Fonts.Inter" Version="$(AvaloniaVersion)" />
         <!--Condition below is needed to remove Avalonia.Diagnostics package from build output in Release configuration.-->
-        <PackageReference Condition="'$(Configuration)' == 'Debug'" Include="Avalonia.Diagnostics" Version="11.0.10" />
+        <PackageReference Condition="'$(Configuration)' == 'Debug'" Include="Avalonia.Diagnostics" Version="$(AvaloniaVersion)" />
         <PackageReference Include="Avalonia.HtmlRenderer" Version="11.0.0" />
-        <PackageReference Include="Avalonia.Labs.Controls" Version="11.0.10.1" />
-        <PackageReference Include="Avalonia.Xaml.Behaviors" Version="11.0.10.1" />
+        <PackageReference Include="Avalonia.Labs.Controls" Version="11.0.3" />
+        <PackageReference Include="Avalonia.Xaml.Behaviors" Version="11.0.6" />
         <PackageReference Include="AvaloniaEdit.TextMate" Version="11.0.6" />
         <PackageReference Include="bodong.Avalonia.PropertyGrid" Version="11.0.6.3" />
         <PackageReference Include="bodong.PropertyModels" Version="11.0.6.2" />
@@ -58,10 +58,10 @@
         <PackageReference Include="DesktopNotifications" Version="1.3.1" />
         <PackageReference Include="DesktopNotifications.Avalonia" Version="1.3.1" />
         <PackageReference Include="DiscordRichPresence" Version="1.2.1.24" />
-        <PackageReference Include="Dock.Avalonia" Version="11.0.0.7" />
-        <PackageReference Include="Dock.Model.Avalonia" Version="11.0.0.7" />
-        <PackageReference Include="Dock.Serializer" Version="11.0.0.7" />
-        <PackageReference Include="DynamicData" Version="8.4.1" />
+        <PackageReference Include="Dock.Avalonia" Version="11.0.0.5" />
+        <PackageReference Include="Dock.Model.Avalonia" Version="11.0.0.5" />
+        <PackageReference Include="Dock.Serializer" Version="11.0.0.5" />
+        <PackageReference Include="DynamicData" Version="8.3.27" />
         <PackageReference Include="DotNet.Bundle" Version="0.9.13" />
         <PackageReference Include="Exceptionless.DateTimeExtensions" Version="3.4.3" />
         <PackageReference Include="FluentAvalonia.BreadcrumbBar" Version="2.0.2" />
@@ -78,25 +78,25 @@
         <PackageReference Include="Microsoft.Extensions.Configuration.FileExtensions" Version="8.0.0" />
         <PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="8.0.0" />
         <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="8.0.0" />
-        <PackageReference Include="Microsoft.Extensions.Http.Polly" Version="8.0.3" />
+        <PackageReference Include="Microsoft.Extensions.Http.Polly" Version="8.0.2" />
         <PackageReference Include="Microsoft.Extensions.Options.ConfigurationExtensions" Version="8.0.0" />
         <PackageReference Include="Nito.AsyncEx" Version="5.1.2" />
         <PackageReference Include="NLog" Version="5.2.8" />
         <PackageReference Include="NLog.Extensions.Logging" Version="5.3.8" />
         <PackageReference Include="NSubstitute" Version="5.1.0" />
         <PackageReference Include="OneOf" Version="3.0.263" />
-        <PackageReference Include="Polly" Version="8.3.1" />
+        <PackageReference Include="Polly" Version="8.3.0" />
         <PackageReference Include="Polly.Contrib.WaitAndRetry" Version="1.1.1" />
         <PackageReference Include="Polly.Extensions.Http" Version="3.0.0" />
-        <PackageReference Include="Projektanker.Icons.Avalonia.FontAwesome" Version="9.1.2" />
+        <PackageReference Include="Projektanker.Icons.Avalonia.FontAwesome" Version="9.1.1" />
         <PackageReference Include="RockLib.Reflection.Optimized" Version="3.0.0" />
-        <PackageReference Include="Sentry" Version="4.2.1" />
-        <PackageReference Include="Sentry.NLog" Version="4.2.1" />
+        <PackageReference Include="Sentry" Version="4.1.2" />
+        <PackageReference Include="Sentry.NLog" Version="4.1.2" />
         <PackageReference Include="SpacedGrid-Avalonia" Version="11.0.0" />
         <PackageReference Include="Sylvan.Common" Version="0.4.3" />
         <PackageReference Include="Sylvan.Data" Version="0.2.13" />
         <PackageReference Include="Sylvan.Data.Csv" Version="1.3.7" />
-        <PackageReference Include="System.Drawing.Common" Version="8.0.3" />
+        <PackageReference Include="System.Drawing.Common" Version="8.0.2" />
         <PackageReference Include="System.IO.Hashing" Version="8.0.0" />
         <PackageReference Include="TextMateSharp.Grammars" Version="1.0.56" />
         <PackageReference Include="URISchemeTools" Version="1.0.2" />

StabilityMatrix.Avalonia/Styles/ControlThemes/BetterComboBoxStyles.axaml

@@ -8,7 +8,8 @@
     xmlns:sg="clr-namespace:SpacedGridControl.Avalonia;assembly=SpacedGridControl.Avalonia"
     xmlns:ui="clr-namespace:FluentAvalonia.UI.Controls;assembly=FluentAvalonia"
     xmlns:labs="clr-namespace:Avalonia.Labs.Controls;assembly=Avalonia.Labs.Controls"
-    xmlns:vendorLabs="clr-namespace:StabilityMatrix.Avalonia.Controls.VendorLabs">
+    xmlns:vendorLabs="clr-namespace:StabilityMatrix.Avalonia.Controls.VendorLabs"
+    xmlns:converters="clr-namespace:StabilityMatrix.Avalonia.Converters">
 
     <Design.PreviewWith>
         <Panel Width="450" Height="600">
@@ -29,7 +30,9 @@
             </StackPanel>
         </Panel>
     </Design.PreviewWith>
-
+    
+    <converters:FileUriConverter x:Key="FileUriConverter" />
+    
     <!--  ReSharper disable once Xaml.StaticResourceNotResolved  -->
     <ControlTheme
         x:Key="BetterComboBoxItemHybridModelTheme"
@@ -50,7 +53,7 @@
                         CornerRadius="6"
                         IsVisible="{Binding Local.PreviewImageFullPathGlobal, Converter={x:Static StringConverters.IsNotNullOrEmpty}, FallbackValue=''}"
                         RenderOptions.BitmapInterpolationMode="HighQuality"
-                        Source="{Binding Local.PreviewImageFullPathGlobal, FallbackValue=''}"
+                        Source="{Binding Local.PreviewImageFullPathGlobal, FallbackValue='', Converter={StaticResource FileUriConverter}}"
                         Stretch="UniformToFill"/>
                     <StackPanel
                         Grid.Column="1"
@@ -132,7 +135,7 @@
                             Height="42"
                             RenderOptions.BitmapInterpolationMode="HighQuality"
                             CornerRadius="40"
-                            Source="{Binding Local.PreviewImageFullPathGlobal}"
+                            Source="{Binding Local.PreviewImageFullPathGlobal, Converter={StaticResource FileUriConverter}}"
                             Stretch="UniformToFill"/>
 
                         <!--  Text  -->
@@ -220,7 +223,7 @@
                             Height="36"
                             CornerRadius="60"
                             RenderOptions.BitmapInterpolationMode="HighQuality"
-                            Source="{Binding Local.PreviewImageFullPathGlobal}"
+                            Source="{Binding Local.PreviewImageFullPathGlobal, Converter={StaticResource FileUriConverter}}"
                             Stretch="UniformToFill">
                         </vendorLabs:BetterAsyncImage>
 

StabilityMatrix.Avalonia/ViewModels/Base/InferenceTabViewModelBase.cs

@@ -18,6 +18,7 @@ using FluentAvalonia.UI.Media.Animation;
 using Microsoft.Extensions.DependencyInjection;
 using NLog;
 using StabilityMatrix.Avalonia.Animations;
+using StabilityMatrix.Avalonia.Extensions;
 using StabilityMatrix.Avalonia.Models;
 using StabilityMatrix.Avalonia.Models.Inference;
 using StabilityMatrix.Avalonia.Services;
@@ -249,7 +250,7 @@ public abstract partial class InferenceTabViewModelBase
         // 1. Context drop for LocalImageFile
         if (e.Data.GetDataFormats().Contains("Context"))
         {
-            if (e.Data.Get("Context") is LocalImageFile imageFile)
+            if (e.Data.GetContext<LocalImageFile>() is { } imageFile)
             {
                 e.Handled = true;
                 return;
@@ -274,7 +275,7 @@ public abstract partial class InferenceTabViewModelBase
         // 1. Context drop for LocalImageFile
         if (e.Data.GetDataFormats().Contains("Context"))
         {
-            if (e.Data.Get("Context") is LocalImageFile imageFile)
+            if (e.Data.GetContext<LocalImageFile>() is { } imageFile)
             {
                 e.Handled = true;
 

StabilityMatrix.Avalonia/ViewModels/CheckpointManager/CheckpointFolder.cs

@@ -15,6 +15,7 @@ using CommunityToolkit.Mvvm.Input;
 using DynamicData;
 using DynamicData.Binding;
 using FluentAvalonia.UI.Controls;
+using StabilityMatrix.Avalonia.Extensions;
 using StabilityMatrix.Avalonia.Services;
 using StabilityMatrix.Avalonia.ViewModels.Base;
 using StabilityMatrix.Core.Attributes;
@@ -279,7 +280,7 @@ public partial class CheckpointFolder : ViewModelBase
                 var paths = files.Select(f => f.Path.LocalPath).ToArray();
                 await ImportFilesAsync(paths, settingsManager.Settings.IsImportAsConnected);
             }
-            else if (e.Data.Get("Context") is CheckpointFile file)
+            else if (e.Data.GetContext<CheckpointFile>() is { } file)
             {
                 await MoveBetweenFolders(file);
             }

StabilityMatrix.Avalonia/Views/CheckpointsPage.axaml.cs

@@ -6,6 +6,7 @@ using Avalonia.Markup.Xaml;
 using Avalonia.VisualTree;
 using DynamicData.Binding;
 using StabilityMatrix.Avalonia.Controls;
+using StabilityMatrix.Avalonia.Extensions;
 using StabilityMatrix.Avalonia.ViewModels;
 using StabilityMatrix.Avalonia.ViewModels.CheckpointManager;
 using StabilityMatrix.Core.Attributes;
@@ -68,7 +69,7 @@ public partial class CheckpointsPage : UserControlBase
         {
             case CheckpointFolder folder:
             {
-                if (e.Data.Get("Context") is not CheckpointFile file)
+                if (e.Data.GetContext<CheckpointFile>() is not { } file)
                 {
                     await folder.OnDrop(e);
                     break;
@@ -83,7 +84,7 @@ public partial class CheckpointsPage : UserControlBase
             }
             case CheckpointFile file:
             {
-                if (e.Data.Get("Context") is not CheckpointFile dragFile)
+                if (e.Data.GetContext<CheckpointFile>() is not { } dragFile)
                 {
                     await file.ParentFolder.OnDrop(e);
                     break;
@@ -132,7 +133,7 @@ public partial class CheckpointsPage : UserControlBase
             case CheckpointFolder folder:
             {
                 folder.IsExpanded = true;
-                if (e.Data.Get("Context") is not CheckpointFile file)
+                if (e.Data.GetContext<CheckpointFile>() is not { } file)
                 {
                     folder.IsCurrentDragTarget = true;
                     break;
@@ -144,7 +145,7 @@ public partial class CheckpointsPage : UserControlBase
             }
             case CheckpointFile file:
             {
-                if (e.Data.Get("Context") is not CheckpointFile dragFile)
+                if (e.Data.GetContext<CheckpointFile>() is not { } dragFile)
                 {
                     file.ParentFolder.IsCurrentDragTarget = true;
                     break;

StabilityMatrix.Avalonia/Views/ConsoleOutputPage.axaml

@@ -89,6 +89,7 @@
                     Classes="accent"
                     IsDefault="True"
                     Content="{x:Static lang:Resources.Action_Send}"
+                    IsEnabled="{Binding IsRunning}"
                     Command="{Binding SendToConsoleCommand}"/>
         </Grid>
         

StabilityMatrix.Core/StabilityMatrix.Core.csproj

@@ -27,7 +27,7 @@
       <PackageReference Include="DeviceId.Windows" Version="6.6.0" />
       <PackageReference Include="DeviceId.Windows.Wmi" Version="6.6.0" />
       <PackageReference Include="DotNet.Bundle" Version="0.9.13" />
-      <PackageReference Include="DynamicData" Version="8.4.1" />
+      <PackageReference Include="DynamicData" Version="8.3.27" />
       <PackageReference Include="ExifLibNet" Version="2.1.4" />
       <PackageReference Include="FreneticLLC.FreneticUtilities" Version="1.0.24" />
       <PackageReference Include="Hardware.Info" Version="100.1.0" />
@@ -45,7 +45,7 @@
       <PackageReference Include="Octokit" Version="10.0.0" />
       <PackageReference Include="OneOf" Version="3.0.263" />
       <PackageReference Include="OneOf.SourceGenerator" Version="3.0.263" />
-      <PackageReference Include="Polly" Version="8.3.1" />
+      <PackageReference Include="Polly" Version="8.3.0" />
       <PackageReference Include="Polly.Contrib.WaitAndRetry" Version="1.1.1" />
       <PackageReference Include="pythonnet" Version="3.0.3" />
       <PackageReference Include="Refit" Version="7.0.0" />
@@ -53,7 +53,7 @@
       <PackageReference Include="RockLib.Reflection.Optimized" Version="3.0.0" />
       <PackageReference Include="Salaros.ConfigParser" Version="0.3.8" />
       <PackageReference Include="Semver" Version="3.0.0-beta.1" />
-      <PackageReference Include="Sentry.NLog" Version="4.2.1" />
+      <PackageReference Include="Sentry.NLog" Version="4.1.2" />
       <PackageReference Include="SharpCompress" Version="0.36.0" />
       <PackageReference Include="SkiaSharp" Version="2.88.7" />
       <PackageReference Include="Websocket.Client" Version="5.1.1" />

StabilityMatrix.UITests/StabilityMatrix.UITests.csproj

@@ -15,7 +15,7 @@
     </PropertyGroup>
 
     <ItemGroup>
-        <PackageReference Include="Avalonia.Headless.XUnit" Version="11.0.10" />
+        <PackageReference Include="Avalonia.Headless.XUnit" Version="$(AvaloniaVersion)" />
         <PackageReference Include="DotNet.Bundle" Version="0.9.13" />
         <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.9.0" />
         <PackageReference Include="NSubstitute" Version="5.1.0" />